Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run integration tests for OS'es older than Windows 2016 #53057

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Don't run integration tests for OS'es older than Windows 2016 #53057

merged 1 commit into from
Feb 27, 2019

Conversation

it-praktyk
Copy link
Contributor

SUMMARY

The pull request disables running of integration test on Windows Server 2008, 2008R2, 2012, 2012 R2 due that PowerShell >= 5.0 is required to run tests.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_dsc
win_firewall

ADDITIONAL INFORMATION

It should be backported to versions 2.5-2.7 too.

@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

cc @dagwieers @if-meaton @jborean93 @jhawkesworth @michaeldeaton @nitzmahone @trondhindenes
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Feb 27, 2019
@dagwieers
Copy link
Contributor

The tests cover this usually based on capabilities, which is our preferred way of doing it.

ansible/test/integration/targets/win_dsc/tasks/main.yml

Line 34 in 79eeea8

when: powershell_version.stdout_lines[0]|int >= 5

This means that if our targets would be upgraded to PowerShell 5 the tests would run.

The fact that our CI reports no errors means this is working fine as-is.

@dagwieers dagwieers closed this Feb 27, 2019
@it-praktyk
Copy link
Contributor Author

it-praktyk commented Feb 27, 2019 •
edited

@dagwieers,
recently, I was asked about that (skip spin-up Windows Server 2008, 2008 R2 under CI) by @jborean93.

Can you discuss that case with @jborean93, please?

@dagwieers dagwieers reopened this Feb 27, 2019
@dagwieers
Copy link
Contributor

@it-praktyk Ok, I wasn't aware. Re-opened :-)

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 27, 2019
@jborean93
Copy link
Contributor

Looks good, thanks for doing this.

@dagwieers this means CI won't have to wait until the hosts hosts are ready before effectively skipping the test. It saves us both time and money as they don't need to run on them. We still need to keep the conditionals in the test in case we are running it locally though.

@jborean93 jborean93 merged commit c99f3f5 into ansible:devel Feb 27, 2019
it-praktyk added a commit to it-praktyk/ansible that referenced this pull request Feb 28, 2019
@it-praktyk
Don't run integration tests for OS'es older than Windows 2016 (ansibl…
fcf8d45 
…e#53057)
it-praktyk added a commit to it-praktyk/ansible that referenced this pull request Feb 28, 2019
@it-praktyk
Don't run integration tests for OS'es older than Windows 2016 (ansibl…
342395a 
…e#53057)
it-praktyk added a commit to it-praktyk/ansible that referenced this pull request Feb 28, 2019
@it-praktyk
Don't run integration tests for OS'es older than Windows 2016 (ansibl…
6f7f83b 
…e#53057)
This was referenced Feb 28, 2019
Merged
Merged
Merged
@it-praktyk it-praktyk deleted the Optimize_CI_for_Windows branch February 28, 2019 09:50
abadger pushed a commit that referenced this pull request Mar 1, 2019
@it-praktyk @abadger
Don't run integration tests for OS'es older than Windows 2016 (#53057)
8ac0f26
abadger pushed a commit that referenced this pull request Mar 1, 2019
@it-praktyk @abadger
Don't run integration tests for OS'es older than Windows 2016 (#53057)
8ae9f99
mattclay pushed a commit that referenced this pull request Mar 15, 2019
@it-praktyk @mattclay
Don't run integration tests for OS'es older than Windows 2016 (#53057)
58bc9d1
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@it-praktyk @ansibot @dagwieers @jborean93